Expose Issue severity and isFailure as API#1075
Closed
suzannaratcliff wants to merge 1 commit intoswiftlang:mainfrom
Closed
Expose Issue severity and isFailure as API#1075suzannaratcliff wants to merge 1 commit intoswiftlang:mainfrom
suzannaratcliff wants to merge 1 commit intoswiftlang:mainfrom
Conversation
grynspan
reviewed
Apr 14, 2025
| public var severity: Severity | ||
|
|
||
| /// If the issues is a failing issue. | ||
| public var isFailure: Bool { |
Contributor
There was a problem hiding this comment.
I don't think this member is necessary; whether or not a warning is a failure might depend on external configuration (some equivalent to -Werror perhaps.)
grynspan
reviewed
Apr 14, 2025
grynspan
reviewed
Apr 14, 2025
c383628 to
7616fc7
Compare
Contributor
|
@suzannaratcliff @stmontgomery I believe this PR is obsolete? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Expose
Issue SeverityandisFailureas APIMotivation:
To allow users to create issues on their tests without causing the tests to fail, it would be helpful to support creating issues with a warning severity.
Test Warnings:
Severity:
This will allow users to create issues but they will not have to fail the test
Example Usage:
Later on users can inspect the severity of their issue with the severity property.
This API will be useful for teams who would like to inspect if their issue is a failing issue
https://developer.apple.com/documentation/xctest/xctestcase/record(_:)
Modifications:
Checklist: